fix(inkless): bound error-message size on fetch/commit failure paths [KC-410] - #741
Merged
Conversation
jeqo
force-pushed
the
jeqo/fix-bound-msgs
branch
from
August 11, 2026 22:08
805a1d0 to
115fbeb
Compare
jeqo
force-pushed
the
jeqo/fix-bound-msgs
branch
from
August 11, 2026 22:18
115fbeb to
f119ddb
Compare
jeqo
changed the title
Two error paths interpolated an unbounded value into the message, the same class of bug as the S3 bulk-delete fix (#733): - FetchCompleter: the catch-all wrapped the failure with the full fetchInfos.keySet(), which spans every client-requested partition (up to thousands). Report only the partition count. - FileCommitter: logged the whole ClosedFile record, whose toString dumps every aggregated produce request and commit batch. Log a bounded summary (start, request count, batch count, bytes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeqo
force-pushed
the
jeqo/fix-bound-msgs
branch
from
August 12, 2026 16:05
f119ddb to
8b3e6d5
Compare
jeqo
changed the title
jeqo
marked this pull request as ready for review
August 13, 2026 09:08
tvainika
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two error paths interpolated an unbounded value into the message, the same class of bug as the S3 bulk-delete fix (#733):